Skip to content

Empty Clauses#15

Closed
sacado wants to merge 1 commit intowkschwartz:masterfrom
sacado:master
Closed

Empty Clauses#15
sacado wants to merge 1 commit intowkschwartz:masterfrom
sacado:master

Conversation

@sacado
Copy link

@sacado sacado commented Jul 2, 2015

Modified pigosat.AddClauses so that empty clauses are no longer ignored and make the formula unsatisfiable; modified tests consequently.

…ed and make the formula UNSAT ; modified tests consequently
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not seem germaine. What was your reasoning?

@wkschwartz wkschwartz changed the title Modified pigosat.AddClauses so that empty clauses are no longer ignor… Empty Clauses Jul 7, 2015
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this comment is very informative. You can go ahead and kill it.

@wkschwartz
Copy link
Owner

Please amend the docstrings for AddClauses and for type Clause to say that "Empty clauses are no ignored and make a formula unsatisfiable."

@wkschwartz
Copy link
Owner

Ref #14

@wkschwartz
Copy link
Owner

@sacado My goal is to merge this PR once #12 is merged. Would you mind hitting Edit on the PR and click "Allow edits from maintainers"? This will allow me to change some minor things without having to send a PR to your branch first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants