Add support for NOXPYTHON, NOXEXTRAPYTHON and NOXFORCEPYTHON#688
Merged
FollowTheProcess merged 7 commits intowntrblm:mainfrom Feb 15, 2023
edgarrmondragon:feat/python-env-vars
Merged
Add support for NOXPYTHON, NOXEXTRAPYTHON and NOXFORCEPYTHON#688FollowTheProcess merged 7 commits intowntrblm:mainfrom edgarrmondragon:feat/python-env-vars
NOXPYTHON, NOXEXTRAPYTHON and NOXFORCEPYTHON#688FollowTheProcess merged 7 commits intowntrblm:mainfrom
edgarrmondragon:feat/python-env-vars
Conversation
FollowTheProcess
requested changes
Feb 11, 2023
Collaborator
FollowTheProcess
left a comment
FollowTheProcess
left a comment
There was a problem hiding this comment.
Nice! Just a small nit around a docstring. Love the sphinx tabs by the way they look great!
FollowTheProcess
approved these changes
Feb 12, 2023
Collaborator
FollowTheProcess
left a comment
FollowTheProcess
left a comment
There was a problem hiding this comment.
Nice work, LGTM
DiddiLeija
approved these changes
Feb 12, 2023
Collaborator
DiddiLeija
left a comment
DiddiLeija
left a comment
There was a problem hiding this comment.
Thank you @edgarrmondragon!
Contributor
Author
|
I think all the feedback's been addressed. Feel free to merge 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #672