feat(action): do not depend on pipx in Nox action#768
Conversation
|
Do we know if pipx is going to be re-added? We could use this mechanism (both here and in cibuildwheel) until it is. And I wouldn't be shocked if 3.8 was never added to GHA macOS AS, Python didn't officially support AS at that point, it was very experimental. The 3.8 that ships on (at least previous versions of) macOS AS was an Apple patched fork. I'm not sure why 3.9 is missing though, as that had pretty solid support for AS. |
|
The matching PR was merged and released in cibuildwheel. @mayeut can we take this out of draft? |
|
I marked this PR as ready for review as requested by @henryiii pipx is going to be re-added however this PR also deals with self-hosted runners on which pipx might not be available. |
|
AFAICT pipx is just awaiting deployment. I'm not nearly as worried about not using pipx if it's available on all the official runners - a self hosted runner could just add pipx. Maybe we should just add the tests when pipx becomes available? What do others think? I'm fine either way. |
action.yml
Outdated
| with open(os.environ["GITHUB_PATH"], "at") as f: | ||
| f.write(f"{nox_bin_path}\n") | ||
| print("::endgroup::") | ||
| shell: "${{ steps.localpython.outputs.python-path }} -u {0}" |
There was a problem hiding this comment.
| shell: "${{ steps.localpython.outputs.python-path }} -u {0}" | |
| shell: "${{ steps.allpython.outputs.python-path }} -u {0}" |
Not sure using the last activated one makes sense, but it’s what was done before. Seems like only activating 3.6 would be valid, but we must run from 3.7+, for example
There was a problem hiding this comment.
Couldn’t we use localpython?
There was a problem hiding this comment.
at some point, and that's probably still the case, setup-python was allowed to delete some python install to install a more specific one: e.g. you have the latest 3.11.y pre-installed, but specify 3.11.x in the nox action then, 3.11.y is deleted and localpython won't work anymore.
There was a problem hiding this comment.
Ah, makes sense. Should we bump to 3.12 now?
pipx is being re-added in actions/runner-images#9474
blocked by actions/runner-images#9256 (
temp: don't use pipxcommit)blocked by actions/setup-python#808 (
temp: python 3.8 & 3.9 missing on macos-14commit)