Merged
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
cjolowicz
approved these changes
Apr 7, 2024
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Closed
jezdez
reviewed
Apr 15, 2024
Comment on lines
-557
to
+559
| needed. | ||
| needed. It is highly recommended to specify this; micromamba does not | ||
| set default channels, and default channels vary for conda. Note that | ||
| "defaults" is also not permissivly licenced like "conda-forge" is. |
There was a problem hiding this comment.
@henryiii This sounds ominous, Anaconda's defaults channel is commercially licensed and is free to use for educational users and companies with fewer than 200 employees.
jezdez
reviewed
Apr 15, 2024
| for v in self.venv_params | ||
| ): | ||
| # Micromamba doesn't have any default channels | ||
| cmd.append("--channel=conda-forge") |
There was a problem hiding this comment.
It might be worth mentioning this default in the docs as it is not quite the same as relying on PyPI (which doesn't re-package software from 3rd party authors as conda-forge does). Linking to the conda-forge security considerations would be even better to inform users about that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds micromamba support alongside the existing conda and mamba support. Micromamba is a version of mamba using C++ completely, not requiring Python. It's very useful for CI systems and anywhere a single binary is easier to work with.
Fix #680.