Update type annotation of stderr parameter to make it optional#835
Merged
cjolowicz merged 1 commit intowntrblm:mainfrom Jun 27, 2024
edgarrmondragon:typing-stderr-optional
Merged
Update type annotation of stderr parameter to make it optional#835cjolowicz merged 1 commit intowntrblm:mainfrom edgarrmondragon:typing-stderr-optional
stderr parameter to make it optional#835cjolowicz merged 1 commit intowntrblm:mainfrom
edgarrmondragon:typing-stderr-optional
Conversation
cjolowicz
approved these changes
Jun 26, 2024
Collaborator
cjolowicz
left a comment
There was a problem hiding this comment.
LGTM. If you want to get the command output using the silent flag, passing stderr as None prevents mingling stdout and stderr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is used, for example, by nox-poetry: https://github.com/cjolowicz/nox-poetry/blob/fb20b69892d394e8a4b97ae4d1f1d06cf811d32f/src/nox_poetry/poetry.py#L91