Skip to content

Update type annotation of stderr parameter to make it optional#835

Merged
cjolowicz merged 1 commit intowntrblm:mainfrom
edgarrmondragon:typing-stderr-optional
Jun 27, 2024
Merged

Update type annotation of stderr parameter to make it optional#835
cjolowicz merged 1 commit intowntrblm:mainfrom
edgarrmondragon:typing-stderr-optional

Conversation

@edgarrmondragon
Copy link
Copy Markdown
Contributor

@edgarrmondragon edgarrmondragon commented Jun 25, 2024

Copy link
Copy Markdown
Collaborator

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you want to get the command output using the silent flag, passing stderr as None prevents mingling stdout and stderr.

@cjolowicz cjolowicz merged commit 4fb39b6 into wntrblm:main Jun 27, 2024
@edgarrmondragon edgarrmondragon deleted the typing-stderr-optional branch June 28, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants