Merged
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
DiddiLeija
approved these changes
Oct 8, 2024
Collaborator
DiddiLeija
left a comment
DiddiLeija
left a comment
There was a problem hiding this comment.
Looks good to me! :)
Also I'll try to take a look to the other docs PRs so we can push a new release ASAP ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This had a lot of cruft that is not needed with nox. First, the working directory is guaranteed to be the noxfile directory, so all the path stuff wasn't needed. Second, we now support default=False, so use that. Third, we don't support multiline help yet so all the extra stuff isn't visible unless you are looking at the code anyway. Finally, we can just use the correct path to pip. We could use external pip instead, and leave it out of the dev environment, but this seems fine as an example.