fix: warning about __main__ already being imported#884
Merged
henryiii merged 1 commit intowntrblm:mainfrom Nov 5, 2024
Merged
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/fix/mainwarning
branch
from
446b310 to
8fa3251
Compare
Closed
cjolowicz
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #878, fixing a warning about
__main__already being imported when running__main__(I think it messes with theif __name__ == "__main__"statement when you usepython -m noxand that imports__init__and that triggers the__main__import early).Fixed by moving
__main__.pycontents to_cli.pythen importing from there for__init__.pyand__main__.py. Backward compatible.Noticed in #881.