feat!: add useVueOTPContext, forwardRef with $el#19
Merged
wobsoriano merged 14 commits intowobsoriano:mainfrom Nov 1, 2025
Merged
feat!: add useVueOTPContext, forwardRef with $el#19wobsoriano merged 14 commits intowobsoriano:mainfrom
wobsoriano merged 14 commits intowobsoriano:mainfrom
Conversation
defineExpose $el instead of ref
|
@sadeghbarati is attempting to deploy a commit to the Robert Soriano's projects Team on Vercel. A member of the Team first needs to authorize it. |
8 tasks
move attrs outside of the computed and use in template since $attrs are readonly and must not be reactive
Owner
|
Thanks so much brother! I will review it over the weekend 👍🏼 Appreciate it |
add _beforeInputListener for preventing selectionchange conflict with input event (thanks grok :) removed use-previous and use vueuse function
wobsoriano
approved these changes
Nov 1, 2025
Owner
wobsoriano
left a comment
wobsoriano
left a comment
There was a problem hiding this comment.
This looks good. I'm merging this.
I'll also make another update soon to match with the changes in the input-otp repo
thanks once again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wobsoriano Hello Robert sry for direct mention and big PR,
We are using this lib in v4 registry of
shadcn-vuethanks for this portWe need to match our OTP component with main
shadcn-uiwhich uses contextHere the list of changes:
$elinstead ofrefso user could retrieves the underlying DOM withunrefElement