Fix leading zero having different font #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
a067b23 to
5e58d95
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
acd6c81 to
a337cde
Compare
wojtekmaj
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'd like to start out by saying thanks for putting together this awesome library!
I ran into an intriguing glitch using this library in a project where we have custom fonts. There was inconsistency in the font display for the leading zero in the time input. With some research, I discovered that 'font' for the leading zero was not inherited from its parent.
To solve this, I've added the CSS rule
font: inheritto the__inputGroup__leadingZeroclass. This aligns the font display of the leading zero with the rest of the input. I believe this fix will make the component more consistent when it comes to font styling.Images
Before
After
This ensures the styling consistency between all elements of the component, providing a more predictable experience for future users.