Skip to content

ISSUE:7121 - warning when try to create multiple products with the same SKU (product duplication improvement and test)#1

Merged
wokisajn merged 1 commit intowokisajn:issue-7121-warning-multiple-products-same-skufrom
ecomchallenger:issue-7121-warning-multiple-products-same-sku
May 30, 2018
Merged

ISSUE:7121 - warning when try to create multiple products with the same SKU (product duplication improvement and test)#1
wokisajn merged 1 commit intowokisajn:issue-7121-warning-multiple-products-same-skufrom
ecomchallenger:issue-7121-warning-multiple-products-same-sku

Conversation

@ecomchallenger
Copy link
Copy Markdown

@ecomchallenger ecomchallenger commented May 25, 2018

ISSUE:7121 - warning when try to create multiple products with the same SKU (Improvement for product duplication and integration tests)

Description

  • Improvement for product duplication for admin area, when saving the product by choosing: Save & Duplicate
  • Adding a product with the same sku is still not allowed
  • Fixes in integration tests

Manual testing scenarios

  1. Choose Save & duplicate in admin product edit form. Product should be successfully saved and an edit form with the duplicated product data should be opened (previously it was not possible because of an exception about duplicated sku)
  2. Try to add product with already existing product sku (via admin area or api). An exception should be thrown with message about duplicated sku.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ecomchallenger
Copy link
Copy Markdown
Author

Hi @wokisajn, would You be able to take a look at this PR?

Cheers

… (Integration tests, improvement for product duplication)
@ecomchallenger ecomchallenger force-pushed the issue-7121-warning-multiple-products-same-sku branch from 28649f2 to 545575d Compare May 30, 2018 08:05
@wokisajn wokisajn merged commit 12482fc into wokisajn:issue-7121-warning-multiple-products-same-sku May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants