Fix autodetection of RP2350 (ARM mode). #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tjko , Thank you for this fix and all your excellent suggestions / reports. I think we should work on getting you setup as a contributor (I couldn't find one started yet). Can you email support at wolfssl dot com and reference any PR's you've put up? Also please include your location and details about your project. Thanks, |
LinuxJedi
approved these changes
Jul 21, 2025
|
Hi @tjko , your contributor agreement has been approved. Thank you again for your issue reports and fix. We are looking forward to future contributions. |
dgarske
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing wolfSSL on RPi Pico and Pico 2 based on RPi-Pico/CMakeLists.txt and noticed ECC key creation routine (wc_ecc_make_key()) hanging on Pico 2, but working fine on Pico (1).
I traced it down to a hang in sp_256_sqr_8(), which seems to have caused (incorrectly) set
WOLFSSL_SP_ARM_THUMB_ASM. (When compiling withWOLFSSL_SP_ARM_CORTEX_M_ASMthere is no problem on Pico 2).This updates platform detection to look for "rp2350-arm-s" instead "rp2350" in ${PICO_PLATFORM}.