This repository was archived by the owner on May 18, 2025. It is now read-only.
default taxonomy args now filterable, follow-up for #33#68
Open
lkraav wants to merge 1 commit intowoocommerce:masterfrom
Open
default taxonomy args now filterable, follow-up for #33#68lkraav wants to merge 1 commit intowoocommerce:masterfrom
lkraav wants to merge 1 commit intowoocommerce:masterfrom
Conversation
Because it only makes sense from a filtering consistency standpoint. There's plenty of use cases. People might call a "testimonial" with a variety of names ranging from a "case study" to "success story". Accompanying "Categories" may need to called "Industries" etc. Small enough change not to hurt anything while gaining flexibility.
Contributor
Author
|
@jameskoster and co, ping? :) |
Contributor
Author
|
hi @jameskoster, is there anything stopping a quick merge and 1.5.4 release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because it only makes sense from a filtering consistency standpoint.
There's plenty of use cases. People might call a "testimonial" with a
variety of names ranging from a "case study" to "success story".
Accompanying "Categories" may need to called "Industries" etc.
Small enough change not to hurt anything while gaining flexibility.