This repository was archived by the owner on May 18, 2025. It is now read-only.
be able to add a custom class to a quote#71
Open
nticaric wants to merge 1 commit intowoocommerce:masterfrom
Open
be able to add a custom class to a quote#71nticaric wants to merge 1 commit intowoocommerce:masterfrom
nticaric wants to merge 1 commit intowoocommerce:masterfrom
Conversation
Contributor
|
@mendezcode i think this is ok with the exception of adding more sanitization on the class output. You could literally inject anything in there right now. I would say add something like esc_attr() around it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it's not possible to add custom classes to a single quote which might be useful for styling. In my case, I want the quotes to be compatible with bootstrap so I need to be able to add a
col-md-xclass to a single quote.This pull request allows this.