Skip to content

Conversation

renich
Copy link
Contributor

@renich renich commented Apr 11, 2025

It seems the documentation assumed that woodpecker had only one package.

Now, it sets a more complete example by:

  • defining an example RELEASE_VERSION variable.
  • using the variable across the commands.
  • installing all three packages. (maybe cli and agent aren't required, but agent is referenced in the following documentation)

In any case, the commands now actually work.

It seems the documentation assumed that woodpecker had only one package.

Now, it sets a more complete example by:

* defining an example RELEASE_VERSION variable.
* using the variable across the commands.
* installing all three packages. (maybe cli and agent aren't required, but agent is referenced in the following documentation)

In any case, the commands now actually work.
Copy link
Member

@xoxys xoxys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just added a one-liner to auto-capture the latest release.

@xoxys xoxys added the documentation docu & docs label Apr 14, 2025
@xoxys
Copy link
Member

xoxys commented Apr 14, 2025

Could you please also adjust the next docs in https://github.com/woodpecker-ci/woodpecker/tree/main/docs/docs?

@renich
Copy link
Contributor Author

renich commented Apr 17, 2025

Could you please also adjust the next docs in https://github.com/woodpecker-ci/woodpecker/tree/main/docs/docs?

Yep, sure thing. Taking a look at it right now.

Copy link
Contributor Author

@renich renich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we got into more trouble by suing the ${RELEASE_VERSION#v} form. Would you reconsider?

@renich
Copy link
Contributor Author

renich commented Apr 17, 2025

Feel free to revert that last commit (obtaining the version) if you don't like it.

Let me know if you'd reconsider on using the initial version of $RELEASE_VERSION or if you want to stick with ${RELEASE_VERSION#v}.

@xoxys
Copy link
Member

xoxys commented Apr 17, 2025

I think we got into more trouble by suing the ${RELEASE_VERSION#v} form. Would you reconsider?

Can you explain this a bit more?

renich and others added 2 commits April 17, 2025 18:05
It works too and it's simpler.

Co-authored-by: Robert Kaussow <[email protected]>
@renich
Copy link
Contributor Author

renich commented Apr 18, 2025

I think we got into more trouble by suing the ${RELEASE_VERSION#v} form. Would you reconsider?

Can you explain this a bit more?

When we use the ${RELEASE_VERSION#V} version, you have to use that multiple times in the download scripts. It's a subtle change and harder to grasp since it's not common.

On the other hand, if we use ${RELEASE_VERSION}, we only have to add a "v" in the download link and that's it. We're free to use the variable as is for the rest of the commands.

In my opinion, the latter is a tad bit more straight forward and non-confusing.

Copy link
Member

@xoxys xoxys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, lets do it that way :)

Copy link
Member

@xoxys xoxys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again.

@xoxys xoxys enabled auto-merge (squash) April 20, 2025 08:10
@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented Apr 20, 2025

Deployment of preview was torn down

@xoxys xoxys merged commit 1f111d2 into woodpecker-ci:main Apr 20, 2025
7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 19, 2025
1 task
@renich renich deleted the patch-1 branch April 21, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation docu & docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants