-
-
Notifications
You must be signed in to change notification settings - Fork 454
.deb and .rpm installation commands fixed #5087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems the documentation assumed that woodpecker had only one package. Now, it sets a more complete example by: * defining an example RELEASE_VERSION variable. * using the variable across the commands. * installing all three packages. (maybe cli and agent aren't required, but agent is referenced in the following documentation) In any case, the commands now actually work.
docs/versioned_docs/version-3.5/30-administration/05-installation/30-packages.md
Outdated
Show resolved
Hide resolved
docs/versioned_docs/version-3.5/30-administration/05-installation/30-packages.md
Outdated
Show resolved
Hide resolved
docs/versioned_docs/version-3.5/30-administration/05-installation/30-packages.md
Outdated
Show resolved
Hide resolved
docs/versioned_docs/version-3.5/30-administration/05-installation/30-packages.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I just added a one-liner to auto-capture the latest release.
Could you please also adjust the next docs in https://github.com/woodpecker-ci/woodpecker/tree/main/docs/docs? |
Yep, sure thing. Taking a look at it right now. |
…ion/30-packages.md Co-authored-by: Robert Kaussow <[email protected]>
…ion/30-packages.md Co-authored-by: Robert Kaussow <[email protected]>
…ion/30-packages.md Co-authored-by: Robert Kaussow <[email protected]>
…ion/30-packages.md Co-authored-by: Robert Kaussow <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we got into more trouble by suing the ${RELEASE_VERSION#v}
form. Would you reconsider?
See if it's more useful. It uses one less tool (sed) and makes the line shorter.
Feel free to revert that last commit (obtaining the version) if you don't like it. Let me know if you'd reconsider on using the initial version of |
docs/versioned_docs/version-3.5/30-administration/05-installation/30-packages.md
Outdated
Show resolved
Hide resolved
Can you explain this a bit more? |
It works too and it's simpler. Co-authored-by: Robert Kaussow <[email protected]>
…ion/30-packages.md Co-authored-by: Robert Kaussow <[email protected]>
When we use the On the other hand, if we use In my opinion, the latter is a tad bit more straight forward and non-confusing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, lets do it that way :)
docs/versioned_docs/version-3.5/30-administration/05-installation/30-packages.md
Outdated
Show resolved
Hide resolved
docs/versioned_docs/version-3.5/30-administration/05-installation/30-packages.md
Outdated
Show resolved
Hide resolved
docs/versioned_docs/version-3.5/30-administration/05-installation/30-packages.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Robert Kaussow <[email protected]>
…ion/30-packages.md Co-authored-by: Robert Kaussow <[email protected]>
…ion/30-packages.md Co-authored-by: Robert Kaussow <[email protected]>
…ion/30-packages.md Co-authored-by: Robert Kaussow <[email protected]>
Co-authored-by: Robert Kaussow <[email protected]>
Co-authored-by: Robert Kaussow <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again.
Deployment of preview was torn down |
It seems the documentation assumed that woodpecker had only one package.
Now, it sets a more complete example by:
In any case, the commands now actually work.