Slugify plugin names used for urls #5098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment of preview was torn down |
anbraten
approved these changes
Apr 17, 2025
|
You are too fast and have not verified it in the preview :D the card links are broken. Ill fix it in a follow up PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLs are pretty ugly now and look even worse if they are used for links somewhere, as it contains a lot of URL encoding.
This PR introduces slugify to create URLs and also handles special chars and Unicode symbols properly. This change will break existing links to the plugin docs, but I would accept this trade-off and fix them afterward.