Skip to content

Conversation

ivaltryek
Copy link
Contributor

Fixes #5238

@ivaltryek
Copy link
Contributor Author

Hey @anbraten , this is my first PR, wanted to fix the issue mentioned in the description. I've tested on my local but I don't have proper setup to test it in the way issue is reported.

i.e

  1. Run the server
  2. Run agent on different clusters / machines
  3. Restart the server
  4. see if the agent across different cluster are still accepting jobs, without restarting the agents.

@qwerty287 qwerty287 added bug Something isn't working agent build_pr_images If set, the CI will build images for this PR and push to Dockerhub labels Jul 14, 2025
@qwerty287
Copy link
Contributor

Thanks @ivaltryek!

For testing, let's ask the reporters: @meetatmoe @greenaar @Deddinho23

Once the CI run at https://ci.woodpecker-ci.org/repos/3780/pipeline/27427 completed, you can use the pull_5323-alpine docker tag.

@Deddinho23
Copy link

Thanks @ivaltryek!

For testing, let's ask the reporters: @meetatmoe @greenaar @Deddinho23

Once the CI run at https://ci.woodpecker-ci.org/repos/3780/pipeline/27427 completed, you can use the pull_5323-alpine docker tag.

Hi guys!
I just did a quick test and it seems to work with this version! If I notice any problems with further use, I'll let you know ASAP. Thanks for now!

@meetatmoe
Copy link

meetatmoe commented Jul 16, 2025

Is the latest agent version is not compatible with server v3.8.0? Getting this error

Hmm, seems like it. any stable server build I can try (released after v3.8.0) ?

NVM, Will try same pull_5323-alpine for server as well.

{"level":"error","error":"GRPC version mismatch","time":"2025-07-16T05:44:08Z","message":"server version 3.8.0 does report grpc version 12 but we only understand 13"}

@meetatmoe
Copy link

@qwerty287 @ivaltryek Just tested now, looks good to me. After server restart, I've triggered few jobs on different agents, they seem to be running on agents without restarts.

@meetatmoe meetatmoe mentioned this pull request Jul 20, 2025
3 tasks
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this for now as it seems to resolve the issue for most users.

@qwerty287
Copy link
Contributor

@ivaltryek
Copy link
Contributor Author

@qwerty287 Please approve the pipeline, Thanks!

@ivaltryek
Copy link
Contributor Author

@qwerty287 Lint is good now, okay to be merged!

@qwerty287 qwerty287 merged commit 5c9fc61 into woodpecker-ci:main Jul 21, 2025
6 of 7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Jul 21, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent bug Something isn't working build_pr_images If set, the CI will build images for this PR and push to Dockerhub
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job pod is not getting created
4 participants