-
-
Notifications
You must be signed in to change notification settings - Fork 454
fix(agent): handle context cancellation #5323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ivaltryek <[email protected]>
Hey @anbraten , this is my first PR, wanted to fix the issue mentioned in the description. I've tested on my local but I don't have proper setup to test it in the way issue is reported. i.e
|
Thanks @ivaltryek! For testing, let's ask the reporters: @meetatmoe @greenaar @Deddinho23 Once the CI run at https://ci.woodpecker-ci.org/repos/3780/pipeline/27427 completed, you can use the |
Hi guys! |
Is the latest agent version is not compatible with server v3.8.0? Getting this error Hmm, seems like it. any stable server build I can try (released after v3.8.0) ? NVM, Will try same
|
@qwerty287 @ivaltryek Just tested now, looks good to me. After server restart, I've triggered few jobs on different agents, they seem to be running on agents without restarts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this for now as it seems to resolve the issue for most users.
@ivaltryek please fix the linter https://ci.woodpecker-ci.org/repos/3780/pipeline/27427/30 |
Signed-off-by: ivaltryek <[email protected]>
@qwerty287 Please approve the pipeline, Thanks! |
@qwerty287 Lint is good now, okay to be merged! |
Fixes #5238