Skip to content

Conversation

anbraten
Copy link
Member

fixes #5408

@anbraten anbraten added the bug Something isn't working label Aug 19, 2025
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 68.57143% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.50%. Comparing base (af5ae4f) to head (e2c334f).

Files with missing lines Patch % Lines
server/forge/setup/setup.go 0.00% 6 Missing ⚠️
server/forge/bitbucket/bitbucket.go 82.75% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5434   +/-   ##
=======================================
  Coverage   26.50%   26.50%           
=======================================
  Files         403      403           
  Lines       28817    28838   +21     
=======================================
+ Hits         7637     7644    +7     
- Misses      20485    20498   +13     
- Partials      695      696    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xoxys xoxys added server forge/bitbucket bitbucket forge related labels Aug 19, 2025
@qwerty287
Copy link
Contributor

Why should we need this? Bitbucket (difference to all other forges) is not self-hostable. It should never be necessary to skip TLS verification or to use a custom oauth host as you can't run it with self-signed certificates or in the same internal network as woodpecker.

@anbraten anbraten changed the title fix: allow to pass oauth-host and skip verify to bitbucket fix: handle empty url and oauth_host on login page Aug 19, 2025
@anbraten anbraten changed the title fix: handle empty url and oauth_host on login page Handle empty url and oauth_host on login page Aug 19, 2025
@anbraten anbraten requested review from qwerty287 and xoxys August 19, 2025 14:12
@anbraten anbraten merged commit dfeb277 into main Aug 19, 2025
7 checks passed
@anbraten anbraten deleted the fix-bb-oauth branch August 19, 2025 15:25
@woodpecker-bot woodpecker-bot mentioned this pull request Aug 20, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forge/bitbucket bitbucket forge related server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not log into new forge
3 participants