Skip to content

Conversation

@Gusted
Copy link
Contributor

@Gusted Gusted commented Sep 9, 2025

In v3.8.0 the following was parsed correctly:

WOODPECKER_PLUGINS_PRIVILEGED="docker.io/woodpeckerci/plugin-docker-buildx:latest, docker.io/woodpeckerci/plugin-docker-buildx:6.0.2"

But in v3.9.0 this would not be parsed correctly and results in the following linter error:

The formerly privileged plugin `woodpeckerci/plugin-docker-buildx:6.0.2` is no longer privileged by default, if required, add it to `WOODPECKER_PLUGINS_PRIVILEGED`

Regression of 59a855c

In v3.8.0 the following was parsed correctly:
WOODPECKER_PLUGINS_PRIVILEGED="docker.io/woodpeckerci/plugin-docker-buildx:latest, docker.io/woodpeckerci/plugin-docker-buildx:6.0.2"

But in v3.9.0 would not be parsed correctly and could in a linter error like:
The formerly privileged plugin `woodpeckerci/plugin-docker-buildx:6.0.2` is no longer privileged by default, if required, add it to `WOODPECKER_PLUGINS_PRIVILEGED`

Regression of 59a855c
@qwerty287 qwerty287 added bug Something isn't working regression fix a bug that was not released yet and removed regression fix a bug that was not released yet labels Sep 9, 2025
@qwerty287
Copy link
Contributor

Thanks!

I guess we have more like this (the StringSliceFlag, I'm not sure if we have more but I'd be surprised if not), could you update this as well? If not I can take care of in the next days.

@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented Sep 9, 2025

Surge PR preview deployment succeeded. View it at https://woodpecker-ci-woodpecker-pr-5494.surge.sh

@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.43%. Comparing base (3a0d225) to head (e922663).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5494      +/-   ##
==========================================
+ Coverage   26.41%   26.43%   +0.01%     
==========================================
  Files         404      404              
  Lines       28842    28842              
==========================================
+ Hits         7620     7625       +5     
+ Misses      20527    20522       -5     
  Partials      695      695              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anbraten anbraten merged commit d2ea85e into woodpecker-ci:main Sep 9, 2025
9 checks passed
@anbraten anbraten changed the title fix: allow spaces in WOODPECKER_PLUGINS_PRIVILEGED fix: allow spaces in cli string slices Sep 9, 2025
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 9, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants