-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Reader: Add Freshly Pressed #24828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Reader: Add Freshly Pressed #24828
Conversation
|
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30002 | |
| Version | PR #24828 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 505077c | |
| Installation URL | 0g9n9g9u5cpk8 |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30002 | |
| Version | PR #24828 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 505077c | |
| Installation URL | 61o785921elb8 |
b524533 to
96c802d
Compare
Generated by 🚫 Danger |
|
| // A workaround for https://linear.app/a8c/issue/CMM-994/reader-invalid-featured-images-for-posts-in-freshly-pressed-feed | ||
| // The app does not support `mshots` images. We also never want to show | ||
| // screenshots of posts as featured images, so it's safe to skip these. | ||
| if ([imageURL containsString:@"wp.com/mshots/"]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured we can opt-out of these on the app side as we never want mshots to be used from the app.
| let topic = context.insertNewObject(ofType: ReaderSiteTopic.self) | ||
| topic.feedURL = path | ||
| topic.path = path | ||
| try? context.save() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have many places in the app that save the main context. Maybe use performAndSave like the rest of the app?





Uh oh!
There was an error while loading. Please reload this page.