-
Notifications
You must be signed in to change notification settings - Fork 17
Draft: 931 feature add role based access control to running workflows #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Draft: 931 feature add role based access control to running workflows #939
Conversation
CodSpeed Performance ReportMerging #939 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #939 +/- ##
==========================================
+ Coverage 83.49% 83.86% +0.37%
==========================================
Files 205 211 +6
Lines 10206 10220 +14
Branches 1022 1008 -14
==========================================
+ Hits 8521 8571 +50
+ Misses 1414 1382 -32
+ Partials 271 267 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e4a5e3a
to
6e33048
Compare
abc0074
to
6a96dae
Compare
authorize_callback: Authorizer | ||
retry_auth_callback: Authorizer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see different arguments for what to name these. For now, I've chosen to not change Alex's naming of authorize_callback
in case it's already in use downstream, but I'm open to feedback on how best to name the following callbacks. Each is a function implementing a RBAC policy.
authorize_callback
: called when a user starts a workflow.resume_auth_callback
: called when a user resumes a workflow paused by aninputstep
. "resume_authorize_callback
" felt a bit unwieldy, but I'm open to it if we want to maintainauthorize_callback
AND make them match.retry_auth_callback
: called when a failed step is retried. Arg to both@workflow
and@inputstep
.
Unlike new_process, this can be checked immediately in the request handler. Policy priorities specified via workflow and steps are resolved via get_auth_callbacks.
a4faed1
to
3bbe13b
Compare
7b508e0
to
dbd45ed
Compare
Here's my first pass at adding auth for inputstep per #931.
I'd appreciate feedback on my present approach, but I'd also like to address the following loose ends before merging:
@workflow
auth interacts with@inputstep
auth and resolving any issues identified in the process.