Skip to content

Make is_task backwards compatible #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2025
Merged

Make is_task backwards compatible #958

merged 4 commits into from
May 29, 2025

Conversation

Igoranze
Copy link
Contributor

See:
#957

Copy link

codspeed-hq bot commented May 28, 2025

CodSpeed Performance Report

Merging #958 will not alter performance

Comparing 957-is-task-compatible (bad1a87) with main (f95b978)

Summary

✅ 12 untouched benchmarks

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.87%. Comparing base (f95b978) to head (bad1a87).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #958   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files         210      210           
  Lines       10186    10186           
  Branches     1003     1003           
=======================================
  Hits         8543     8543           
  Misses       1376     1376           
  Partials      267      267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@pboers1988 pboers1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pboers1988 pboers1988 merged commit eb26d29 into main May 29, 2025
13 checks passed
@pboers1988 pboers1988 deleted the 957-is-task-compatible branch May 29, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants