Skip to content

Conversation

@renjiezh
Copy link
Contributor

No description provided.

@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SanjayVas reviewed 7 of 9 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: 24 of 26 files reviewed, 2 unresolved discussions (waiting on @georgi, @Marco-Premier, and @renjiezh)

@renjiezh renjiezh force-pushed the renjiez-trustee-deployment branch from df6c12c to 5c38d02 Compare December 18, 2025 22:14
Copy link
Contributor Author

@renjiezh renjiezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renjiezh made 2 comments.
Reviewable status: 23 of 26 files reviewed, 2 unresolved discussions (waiting on @georgi, @Marco-Premier, @SanjayVas, and @stevenwarejones).


a discussion (no related file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

To clarify, by (2) I mean the Kotlin code changes and (3) I mean the Terraform/K8s/workflow changes.

Now this is the last piece for TEE mill. Please review again


a discussion (no related file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Make sure to note any breaking changes or relnotes for reusable TF modules.

Done.

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SanjayVas reviewed 17 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @georgi, @Marco-Premier, @renjiezh, and @stevenwarejones).


src/main/terraform/gcloud/cmms/duchies.tf line 56 at r5 (raw file):

    signed_image_repo                  = "ghcr.io/world-federation-of-advertisers/duchy/trus-tee-mill"
    mig_distribution_policy_zones      = ["us-central1-a"]
    disk_image_family                  = "confidential-space-debug"

nit: I assume this is just for initial testing, so add a TODO to switch it

Copy link
Contributor Author

@renjiezh renjiezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renjiezh resolved 1 discussion.
Reviewable status: 25 of 26 files reviewed, all discussions resolved (waiting on @georgi, @Marco-Premier, @SanjayVas, and @stevenwarejones).

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevenwarejones reviewed 26 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @georgi and @Marco-Premier).

Copy link
Contributor Author

@renjiezh renjiezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renjiezh reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @georgi and @Marco-Premier).

@renjiezh renjiezh merged commit 3b8f3b1 into main Dec 21, 2025
11 checks passed
@renjiezh renjiezh deleted the renjiez-trustee-deployment branch December 21, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants