-
Notifications
You must be signed in to change notification settings - Fork 16
feat: Deploy TrusTEE mill in MIG by Terraform #3194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ss-media-measurement into renjiez-trustee-deployment
…ss-media-measurement into renjiez-trustee-deployment
…ss-media-measurement into renjiez-trustee-deployment
…ss-media-measurement into renjiez-trustee-deployment
SanjayVas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SanjayVas reviewed 7 of 9 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: 24 of 26 files reviewed, 2 unresolved discussions (waiting on @georgi, @Marco-Premier, and @renjiezh)
df6c12c to
5c38d02
Compare
renjiezh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renjiezh made 2 comments.
Reviewable status: 23 of 26 files reviewed, 2 unresolved discussions (waiting on @georgi, @Marco-Premier, @SanjayVas, and @stevenwarejones).
a discussion (no related file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
To clarify, by (2) I mean the Kotlin code changes and (3) I mean the Terraform/K8s/workflow changes.
Now this is the last piece for TEE mill. Please review again
a discussion (no related file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
Make sure to note any breaking changes or relnotes for reusable TF modules.
Done.
SanjayVas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SanjayVas reviewed 17 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @georgi, @Marco-Premier, @renjiezh, and @stevenwarejones).
src/main/terraform/gcloud/cmms/duchies.tf line 56 at r5 (raw file):
signed_image_repo = "ghcr.io/world-federation-of-advertisers/duchy/trus-tee-mill" mig_distribution_policy_zones = ["us-central1-a"] disk_image_family = "confidential-space-debug"
nit: I assume this is just for initial testing, so add a TODO to switch it
renjiezh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renjiezh resolved 1 discussion.
Reviewable status: 25 of 26 files reviewed, all discussions resolved (waiting on @georgi, @Marco-Premier, @SanjayVas, and @stevenwarejones).
stevenwarejones
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevenwarejones reviewed 26 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @georgi and @Marco-Premier).
…ion-of-advertisers/cross-media-measurement into renjiez-trustee-deployment
renjiezh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renjiezh reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @georgi and @Marco-Premier).
No description provided.