feat!: Require new permission to create Metrics and BasicReports with DEV ModelLine #3226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
SanjayVas
force-pushed
the
sanjayvas-dev-model-line
branch
from
2e3a488 to
93adad6
Compare
tristanvuong2021
approved these changes
Dec 1, 2025
Contributor
tristanvuong2021
left a comment
tristanvuong2021
left a comment
There was a problem hiding this comment.
@tristanvuong2021 reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
SanjayVas
force-pushed
the
sanjayvas-dev-model-line
branch
from
93adad6 to
72ee941
Compare
SanjayVas
changed the base branch from
main
to
sanjayvas-create-basic-report-validation
SanjayVas
commented
Dec 9, 2025
Member
Author
SanjayVas
left a comment
SanjayVas
left a comment
There was a problem hiding this comment.
Reviewable status: 5 of 8 files reviewed, 1 unresolved discussion (waiting on @Marco-Premier, @SanjayVas, and @tristanvuong2021)
a discussion (no related file):
Working on updating this to have a separate permission for CreateBasicReport.
SanjayVas
force-pushed
the
sanjayvas-dev-model-line
branch
from
72ee941 to
7bfccc9
Compare
SanjayVas
force-pushed
the
sanjayvas-create-basic-report-validation
branch
2 times, most recently
from
57d4f82 to
18d34dc
Compare
SanjayVas
force-pushed
the
sanjayvas-dev-model-line
branch
from
7bfccc9 to
5c98969
Compare
SanjayVas
force-pushed
the
sanjayvas-create-basic-report-validation
branch
from
18d34dc to
679a2c7
Compare
SanjayVas
force-pushed
the
sanjayvas-dev-model-line
branch
2 times, most recently
from
3a6e9cb to
fa1063d
Compare
SanjayVas
force-pushed
the
sanjayvas-create-basic-report-validation
branch
from
679a2c7 to
4ecc6ec
Compare
SanjayVas
force-pushed
the
sanjayvas-dev-model-line
branch
from
fa1063d to
7a20515
Compare
SanjayVas
force-pushed
the
sanjayvas-create-basic-report-validation
branch
2 times, most recently
from
72f8ead to
0606bb5
Compare
SanjayVas
force-pushed
the
sanjayvas-dev-model-line
branch
from
7a20515 to
365e5f9
Compare
SanjayVas
force-pushed
the
sanjayvas-create-basic-report-validation
branch
from
0606bb5 to
734ef7a
Compare
SanjayVas
force-pushed
the
sanjayvas-dev-model-line
branch
from
365e5f9 to
60105fd
Compare
SanjayVas
commented
Dec 9, 2025
Member
Author
SanjayVas
left a comment
SanjayVas
left a comment
There was a problem hiding this comment.
Reviewable status: 4 of 9 files reviewed, all discussions resolved (waiting on @tristanvuong2021)
a discussion (no related file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
Working on updating this to have a separate permission for CreateBasicReport.
Done.
SanjayVas
changed the title
stevenwarejones
approved these changes
Dec 11, 2025
Collaborator
stevenwarejones
left a comment
stevenwarejones
left a comment
There was a problem hiding this comment.
@stevenwarejones reviewed 1 of 8 files at r1, 3 of 5 files at r2, 5 of 5 files at r3, all commit messages.
Reviewable status:
SanjayVas
force-pushed
the
sanjayvas-create-basic-report-validation
branch
from
734ef7a to
a747514
Compare
SanjayVas
force-pushed
the
sanjayvas-dev-model-line
branch
from
60105fd to
08b1c66
Compare
SanjayVas
force-pushed
the
sanjayvas-create-basic-report-validation
branch
from
a747514 to
3e77e27
Compare
SanjayVas
force-pushed
the
sanjayvas-dev-model-line
branch
2 times, most recently
from
603466b to
c885ebd
Compare
SanjayVas
force-pushed
the
sanjayvas-create-basic-report-validation
branch
from
3e77e27 to
fbdf961
Compare
SanjayVas
force-pushed
the
sanjayvas-dev-model-line
branch
from
c885ebd to
bc30e21
Compare
SanjayVas
force-pushed
the
sanjayvas-create-basic-report-validation
branch
from
fbdf961 to
a196d5d
Compare
SanjayVas
force-pushed
the
sanjayvas-dev-model-line
branch
from
bc30e21 to
c76d64d
Compare
SanjayVas
force-pushed
the
sanjayvas-create-basic-report-validation
branch
2 times, most recently
from
a16365b to
e6e3acf
Compare
SanjayVas
force-pushed
the
sanjayvas-dev-model-line
branch
from
c76d64d to
5c80257
Compare
Base automatically changed from
sanjayvas-create-basic-report-validation
to
main
December 17, 2025 00:04
SanjayVas
force-pushed
the
sanjayvas-dev-model-line
branch
from
5c80257 to
8209d62
Compare
SanjayVas
commented
Dec 17, 2025
Member
Author
SanjayVas
left a comment
SanjayVas
left a comment
There was a problem hiding this comment.
@SanjayVas reviewed 4 of 4 files at r4.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3221
Issue: #3221
BREAKING-CHANGE: Creating a Metric (and therefore a Report or BasicReport) using a ModelLine of type DEV requires the Principal to have the
reporting.metrics.createWithDevModelLinepermission.BREAKING-CHANGE: Creating a BasicReport using a ModelLine of type DEV requires the Principal to have the
reporting.basicReports.createWithDevModelLinepermission.