feat: Implement public EventGroup batch create #3234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
roaminggypsy
changed the base branch from
main
to
roaminggypsy-event-group-batch-create-internal
roaminggypsy
force-pushed
the
roaminggypsy-event-group-batch-create-public
branch
from
9894914 to
1e79c87
Compare
SanjayVas
approved these changes
Dec 1, 2025
Member
SanjayVas
left a comment
SanjayVas
left a comment
There was a problem hiding this comment.
@SanjayVas reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @roaminggypsy)
stevenwarejones
approved these changes
Dec 2, 2025
Collaborator
stevenwarejones
left a comment
stevenwarejones
left a comment
There was a problem hiding this comment.
@stevenwarejones reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
roaminggypsy
force-pushed
the
roaminggypsy-event-group-batch-create-internal
branch
3 times, most recently
from
37a2d95 to
56d68dc
Compare
roaminggypsy
force-pushed
the
roaminggypsy-event-group-batch-create-public
branch
from
1e79c87 to
53f918d
Compare
Base automatically changed from
roaminggypsy-event-group-batch-create-internal
to
main
December 4, 2025 23:39
roaminggypsy
force-pushed
the
roaminggypsy-event-group-batch-create-public
branch
2 times, most recently
from
46bcfcf to
d459ce0
Compare
roaminggypsy
changed the title
roaminggypsy
force-pushed
the
roaminggypsy-event-group-batch-create-public
branch
from
52c1755 to
46bf7d0
Compare
# Conflicts: # src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/SpannerEventGroupsService.kt # src/main/kotlin/org/wfanet/measurement/kingdom/service/internal/testing/EventGroupsServiceTest.kt # Conflicts: # src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/SpannerEventGroupsService.kt # src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/writers/BatchCreateEventGroups.kt # src/main/kotlin/org/wfanet/measurement/kingdom/service/internal/testing/EventGroupsServiceTest.kt # src/main/proto/wfa/measurement/internal/kingdom/event_groups_service.proto
# Conflicts: # src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/EventGroupsService.kt # src/test/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/EventGroupsServiceTest.kt
roaminggypsy
force-pushed
the
roaminggypsy-event-group-batch-create-public
branch
from
46bf7d0 to
c240829
Compare
roaminggypsy
commented
Dec 10, 2025
Contributor
Author
roaminggypsy
left a comment
roaminggypsy
left a comment
There was a problem hiding this comment.
@roaminggypsy reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
roaminggypsy
deleted the
roaminggypsy-event-group-batch-create-public
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2450