-
Notifications
You must be signed in to change notification settings - Fork 16
feat: Update gRPC Gateway for BasicReport #3279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update gRPC Gateway for BasicReport #3279
Conversation
…ch-basic-report-needs
…ch-basic-report-needs
…ch-basic-report-needs
SanjayVas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe be more specific that this is removing services that aren't needed by users of the BasicReports service
@SanjayVas reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)
…ch-basic-report-needs
…ch-basic-report-needs
…ch-basic-report-needs
stevenwarejones
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevenwarejones reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Marco-Premier)
tristanvuong2021
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tristanvuong2021 reviewed 2 of 2 files at r1, 2 of 2 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Marco-Premier)
tristanvuong2021
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tristanvuong2021 reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Marco-Premier)
…ch-basic-report-needs
…ch-basic-report-needs
Services that aren't needed by BasicReports are removed from the gRPC Gateway.
Issue: #3278