-
Notifications
You must be signed in to change notification settings - Fork 16
feat: Add Event Group Activities table #3288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
96d0e40 to
cd99265
Compare
SanjayVas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SanjayVas reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @roaminggypsy)
src/main/resources/kingdom/spanner/create-measurement-schema.sql line 17 at r1 (raw file):
-- limitations under the License. -- changeset lindreamdeyi:2 dbms:cloudspanner
You can't modify an existing changeset. You need to add a new changeset to the changelog.
SanjayVas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @roaminggypsy)
src/main/resources/kingdom/spanner/create-measurement-schema.sql line 17 at r1 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
You can't modify an existing changeset. You need to add a new changeset to the changelog.
This means adding a new entry to https://github.com/world-federation-of-advertisers/cross-media-measurement/blob/main/src/main/resources/kingdom/spanner/changelog.yaml
0c311be to
4255fa1
Compare
roaminggypsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
src/main/resources/kingdom/spanner/create-measurement-schema.sql line 17 at r1 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
This means adding a new entry to https://github.com/world-federation-of-advertisers/cross-media-measurement/blob/main/src/main/resources/kingdom/spanner/changelog.yaml
Done.
SanjayVas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SanjayVas reviewed 2 of 3 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @roaminggypsy)
src/main/resources/kingdom/spanner/create-measurement-schema.sql line 17 at r1 (raw file):
Previously, roaminggypsy (Lin) wrote…
Done.
All changes to this file need to be reverted.
src/main/resources/kingdom/spanner/changelog.yaml line 114 at r2 (raw file):
relativeToChangeLogFile: true - include: file: create-event-group-activity-schema.sql
nit: this isn't really a whole schema. Rather, this is just adding a table to an existing schema.
Suggestion:
activities-tabled5e2b5c to
c545b76
Compare
c545b76 to
9205a2e
Compare
roaminggypsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
src/main/resources/kingdom/spanner/create-measurement-schema.sql line 17 at r1 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
All changes to this file need to be reverted.
Done.
SanjayVas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SanjayVas reviewed 3 of 3 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @roaminggypsy)
Marco-Premier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Marco-Premier reviewed 3 of 3 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)
Issue: #3254