Skip to content

Conversation

@roaminggypsy
Copy link
Contributor

@roaminggypsy roaminggypsy commented Dec 4, 2025

Issue: #3254

@wfa-reviewable
Copy link

This change is Reviewable

@roaminggypsy roaminggypsy changed the title feat: add Event Group Activities database schema feat: Add Event Group Activities database schema Dec 4, 2025
Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SanjayVas reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @roaminggypsy)


src/main/resources/kingdom/spanner/create-measurement-schema.sql line 17 at r1 (raw file):

-- limitations under the License.

-- changeset lindreamdeyi:2 dbms:cloudspanner

You can't modify an existing changeset. You need to add a new changeset to the changelog.

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @roaminggypsy)


src/main/resources/kingdom/spanner/create-measurement-schema.sql line 17 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

You can't modify an existing changeset. You need to add a new changeset to the changelog.

This means adding a new entry to https://github.com/world-federation-of-advertisers/cross-media-measurement/blob/main/src/main/resources/kingdom/spanner/changelog.yaml

Copy link
Contributor Author

@roaminggypsy roaminggypsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SanjayVas reviewed 2 of 3 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @roaminggypsy)


src/main/resources/kingdom/spanner/create-measurement-schema.sql line 17 at r1 (raw file):

Previously, roaminggypsy (Lin) wrote…

Done.

All changes to this file need to be reverted.


src/main/resources/kingdom/spanner/changelog.yaml line 114 at r2 (raw file):

    relativeToChangeLogFile: true
- include:
    file: create-event-group-activity-schema.sql

nit: this isn't really a whole schema. Rather, this is just adding a table to an existing schema.

Suggestion:

activities-table

Copy link
Contributor Author

@roaminggypsy roaminggypsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


src/main/resources/kingdom/spanner/create-measurement-schema.sql line 17 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

All changes to this file need to be reverted.

Done.

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SanjayVas reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @roaminggypsy)

@roaminggypsy roaminggypsy changed the title feat: Add Event Group Activities database schema feat: Add Event Group Activities table Dec 11, 2025
Copy link
Collaborator

@Marco-Premier Marco-Premier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Marco-Premier reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)

@roaminggypsy roaminggypsy removed the request for review from stevenwarejones December 11, 2025 09:47
@roaminggypsy roaminggypsy linked an issue Dec 11, 2025 that may be closed by this pull request
@roaminggypsy roaminggypsy merged commit c56796c into main Dec 11, 2025
7 checks passed
@roaminggypsy roaminggypsy deleted the roaminggypsy-ega-db branch December 11, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event Group Activity database schema

5 participants