fix!: Metrics Service now correctly creates a Population Measurement for a Population Metric

[tristanvuong2021]

The Metrics Service is fixed to create a RequisitionSpec with population set.

Issue: #3290
BREAKING-CHANGE: The Reporting public API server has a new required --pdp-name option. This is the resource name of the Population Data Provider (PDP) corresponding to the running Population Requisition Fulfiller instance.

[wfa-reviewable]

This change is 

[SanjayVas]

@SanjayVas reviewed 22 of 22 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @tristanvuong2021)

---

src/main/k8s/local/BUILD.bazel line 248 at r1 (raw file):

cue_dump(
    name = "reporting_v2",
    srcs = ["reporting_v2.cue"],

Drop from srcs since this now comes from deps.

Each file should be in the srcs of no more than one target. I think measurement_system_prober is similarly incorrect and therefore providing a bad example.

---

src/main/k8s/reporting_v2.cue line 291 at r1 (raw file):

						"--port=8443",
						"--health-port=8080",
						"--pdp-name=\(_pdpName)",

I believe the references in this file need to be _populationDataProviderName

Suggestion:

_populationDataProviderName

---

src/main/k8s/reporting_v2.cue line 316 at r1 (raw file):

						"--port=8443",
						"--health-port=8080",
						"--pdp-name=\(_pdpName)",

Suggestion:

_populationDataProviderName

[tristanvuong2021]

Reviewable status: 20 of 22 files reviewed, 3 unresolved discussions (waiting on @SanjayVas)

---

src/main/k8s/reporting_v2.cue line 291 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

I believe the references in this file need to be _populationDataProviderName

Done.

---

src/main/k8s/local/BUILD.bazel line 248 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Drop from srcs since this now comes from deps.

Each file should be in the srcs of no more than one target. I think measurement_system_prober is similarly incorrect and therefore providing a bad example.

Done.

---

src/main/k8s/reporting_v2.cue line 316 at r1 (raw file):

						"--port=8443",
						"--health-port=8080",
						"--pdp-name=\(_pdpName)",

Done.

[SanjayVas]

@SanjayVas reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)

[stevenwarejones]

@stevenwarejones reviewed 20 of 22 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)

[tristanvuong2021]

@tristanvuong2021 reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)

[tristanvuong2021]

@tristanvuong2021 reviewed 19 of 22 files at r1, 2 of 2 files at r2, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)