fix: set max frequency below the ring modulus

[stevenwarejones]

The default max frequency is limited by two things:

1. The size in the frequency vector (Byte.MAX_VALUE)
2. The Ring Modulus used for HMShuffle

[wfa-reviewable]

This change is 

[kungfucraig]

@kungfucraig reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)

---

src/main/kotlin/org/wfanet/measurement/computation/KAnonymityParams.kt line 32 at r1 (raw file):

  val minUsers: Int,
  val minImpressions: Int,
  val reachMaxFrequencyPerUser: Int = 126,

Can these two things reference the same constant, perhaps defined in a third file?

[stevenwarejones]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kungfucraig)

---

src/main/kotlin/org/wfanet/measurement/computation/KAnonymityParams.kt line 32 at r1 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

Can these two things reference the same constant, perhaps defined in a third file?

Unfortunately, this is part of the protocol config configured in the kingdom. I'd think we'd need to think about how to maintain consistency across these configs. we could add a param for the kingdom ring modulus. I don't want to have to add that param since we are moving to TrusTee anyways.

[stevenwarejones]

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @kungfucraig)

---

src/main/kotlin/org/wfanet/measurement/computation/KAnonymityParams.kt line 32 at r1 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

Unfortunately, this is part of the protocol config configured in the kingdom. I'd think we'd need to think about how to maintain consistency across these configs. we could add a param for the kingdom ring modulus. I don't want to have to add that param since we are moving to TrusTee anyways.

actually - went ahead and put it in a separate params file

[kungfucraig]

@kungfucraig reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)

---

src/main/kotlin/org/wfanet/measurement/computation/KAnonymityParams.kt line 32 at r1 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

actually - went ahead and put it in a separate params file

Thanks. I think keeping it consistent across EDPA and the Kingdom is a separate challenge, but consistency within EDPA is nice.

[stevenwarejones]

@stevenwarejones reviewed 1 of 5 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)