fix: Add additional validation to ImpressionQualificationFilterConfig #3316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tristanvuong2021
changed the title
SanjayVas
approved these changes
Dec 15, 2025
Member
SanjayVas
left a comment
SanjayVas
left a comment
There was a problem hiding this comment.
@SanjayVas reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)
stevenwarejones
approved these changes
Dec 17, 2025
Collaborator
stevenwarejones
left a comment
stevenwarejones
left a comment
There was a problem hiding this comment.
@stevenwarejones reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
tristanvuong2021
deleted the
tristanvuong-prevent-missing-filters-in-IQF-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional validation to ImpressionQualificationFilterConfig. Testing has exposed missing validation.
Issue: #3315