Skip to content

Conversation

@SanjayVas
Copy link
Member

Issue: #3329

@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas SanjayVas enabled auto-merge (squash) December 15, 2025 19:15
Copy link
Contributor

@laureanobrs laureanobrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laureanobrs reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


.github/workflows/build-test.yml line 136 at r1 (raw file):

          echo "exclusion_filter=${exclusion_filter}" >> "$GITHUB_OUTPUT"

      - name: Run tests with coverage

Another option is to remove only the exclusions computation step and the Kotlin coverage and let the rest keep working. I agree with either of the two.

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)


.github/workflows/build-test.yml line 136 at r1 (raw file):

Previously, laureanobrs wrote…

Another option is to remove only the exclusions computation step and the Kotlin coverage and let the rest keep working. I agree with either of the two.

Given that the majority of our code is in Kotlin, I don't see a huge value in keeping coverage running without that.

@SanjayVas SanjayVas merged commit 1f89750 into main Dec 15, 2025
5 checks passed
@SanjayVas SanjayVas deleted the sanjayvas-coverage branch December 15, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants