fix: Update TrusTEE mill to use StreamingAead

[renjiezh]

No description provided.

[wfa-reviewable]

This change is 

[SanjayVas]

@SanjayVas reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @renjiezh)

---

src/main/kotlin/org/wfanet/measurement/duchy/mill/trustee/TrusTeeMill.kt line 224 at r1 (raw file):

  }

  private fun decryptRequisitionData(dek: KeysetHandle, data: ByteString): ByteArray {

nit: This isn't really taking advantage of the streaming aspect. The idea is to pass in each chunk while reading the blob, meaning you'd need to change getRequisitionData. See StreamingAead.decrypt in common-jvm.

Of course, there's less benefit if you need the whole plaintext in memory, but it still avoids having both the full plaintext and ciphertext in memory at the same time.

Maybe leave a TODO?

[renjiezh]

Reviewable status: 3 of 5 files reviewed, all discussions resolved (waiting on @SanjayVas)

---

src/main/kotlin/org/wfanet/measurement/duchy/mill/trustee/TrusTeeMill.kt line 224 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

nit: This isn't really taking advantage of the streaming aspect. The idea is to pass in each chunk while reading the blob, meaning you'd need to change getRequisitionData. See StreamingAead.decrypt in common-jvm.

Of course, there's less benefit if you need the whole plaintext in memory, but it still avoids having both the full plaintext and ciphertext in memory at the same time.

Maybe leave a TODO?

Added a TODO.

[stevenwarejones]

@stevenwarejones reviewed 2 of 5 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @renjiezh)

---

src/main/kotlin/org/wfanet/measurement/duchy/mill/trustee/TrusTeeMill.kt line 229 at r2 (raw file):

      val streamingAead = dek.getPrimitive(StreamingAead::class.java)
      val decryptingStream = streamingAead.newDecryptingStream(data.newInput(), byteArrayOf())
      return decryptingStream.readAllBytes()

i'd prefer this leverage/get combined with existing common-jvm classes like WithEnvelopeEncryption or StreamingEncryption or StreamingAeadStorageClient

[renjiezh]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)

---

src/main/kotlin/org/wfanet/measurement/duchy/mill/trustee/TrusTeeMill.kt line 229 at r2 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

i'd prefer this leverage/get combined with existing common-jvm classes like WithEnvelopeEncryption or StreamingEncryption or StreamingAeadStorageClient

That is a good point. I have created an ticket [https://github.com//issues/2800] for it.
Now my PRs are stacking on each other. It takes time for me to verify these type of change. Can we get PRs merged and then work on the improvements?

[stevenwarejones]

@stevenwarejones reviewed 1 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @renjiezh)