-
Notifications
You must be signed in to change notification settings - Fork 16
Add edp impression path to data availability config #3342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add edp impression path to data availability config #3342
Conversation
Marco-Premier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Marco-Premier reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)
kungfucraig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kungfucraig reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)
a discussion (no related file):
Per offline discussion this is a breaking change and updates will be made to make the EDP path optional to start.
stevenwarejones
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 5 files reviewed, 1 unresolved discussion (waiting on @kungfucraig and @Marco-Premier)
a discussion (no related file):
Previously, kungfucraig (Craig Wright) wrote…
Per offline discussion this is a breaking change and updates will be made to make the EDP path optional to start.
Done.
kungfucraig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kungfucraig reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)
…availability_paths
The current regex check in the DataAvailabilitySync does not distinguish if the wrong edp path was given.
Adds a param to check if the correct EDPs data is included. Adds better tests for realistic path names with model lines in them.
Issue: #3360