Skip to content

Conversation

@stevenwarejones
Copy link
Collaborator

@stevenwarejones stevenwarejones commented Dec 16, 2025

The current regex check in the DataAvailabilitySync does not distinguish if the wrong edp path was given.
Adds a param to check if the correct EDPs data is included. Adds better tests for realistic path names with model lines in them.

Issue: #3360

@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Collaborator

@Marco-Premier Marco-Premier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Marco-Premier reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)

Copy link
Member

@kungfucraig kungfucraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kungfucraig reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)


a discussion (no related file):
Per offline discussion this is a breaking change and updates will be made to make the EDP path optional to start.

Copy link
Collaborator Author

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 5 files reviewed, 1 unresolved discussion (waiting on @kungfucraig and @Marco-Premier)


a discussion (no related file):

Previously, kungfucraig (Craig Wright) wrote…

Per offline discussion this is a breaking change and updates will be made to make the EDP path optional to start.

Done.

Copy link
Member

@kungfucraig kungfucraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kungfucraig reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)

@stevenwarejones stevenwarejones merged commit e6d3f30 into main Dec 17, 2025
5 checks passed
@stevenwarejones stevenwarejones deleted the stevenwarejones_data_availability_paths branch December 17, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants