fix(report-processor): correct the metric_subset_by_parent map for reports without AMI measurements #3344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port without AMI measurements.
|
This change is |
tristanvuong2021
approved these changes
Dec 16, 2025
Contributor
tristanvuong2021
left a comment
tristanvuong2021
left a comment
There was a problem hiding this comment.
@tristanvuong2021 reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @kungfucraig)
kungfucraig
approved these changes
Dec 16, 2025
Member
kungfucraig
left a comment
kungfucraig
left a comment
There was a problem hiding this comment.
@kungfucraig reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:
stevenwarejones
approved these changes
Dec 17, 2025
Collaborator
stevenwarejones
left a comment
stevenwarejones
left a comment
There was a problem hiding this comment.
@stevenwarejones reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #3343.
RELNOTES: The post processor requires that ImpressionQualificationFilters named "mrc" and "ami" exist. This Issue will be corrected in the future so that the specific names are flexible.