-
Notifications
You must be signed in to change notification settings - Fork 16
fix(report-processor): verify k-reach is not empty when getting its edp combinations. #3353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tristanvuong2021
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tristanvuong2021 reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @kungfucraig and @ple13).
src/main/python/wfa/measurement/reporting/postprocessing/report/report.py line 483 at r1 (raw file):
for edp in self._weekly_non_cumulative_measurements.keys() if len(self._weekly_non_cumulative_measurements[edp]) > 0 and self._weekly_non_cumulative_measurements[edp][0].k_reach
Does this fix need to be applied in other places. I only tested reach so far
kungfucraig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kungfucraig reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021).
src/main/python/wfa/measurement/reporting/postprocessing/report/report.py line 483 at r1 (raw file):
Previously, tristanvuong2021 (Tristan Vuong) wrote…
Does this fix need to be applied in other places. I only tested reach so far
+1
ple13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ple13 made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021).
src/main/python/wfa/measurement/reporting/postprocessing/report/report.py line 483 at r1 (raw file):
Previously, kungfucraig (Craig Wright) wrote…
+1
Yeah, this is the only place that caused the issue. It returns a wrong set of edp combinations for k-reach.
tristanvuong2021
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tristanvuong2021 resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones).
tristanvuong2021
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tristanvuong2021 reviewed 2 files.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones).
stevenwarejones
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevenwarejones reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ple13).
This PR closes #3352.