feat: Flashblocks metrics #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cichaczem
requested review from
0xForerunner,
0xOsiris,
Dzejkop and
karankurbur
as code owners
0xOsiris
approved these changes
Sep 18, 2025
| let flashblock = Flashblock::new(payload, self.config.clone(), self.block_index, offset); | ||
| trace!(target: "payload_builder", id=%self.config.payload_id(), "creating authorized flashblock"); | ||
|
|
||
| let flashblock_bytes = bincode::serialize(&flashblock) |
Contributor
There was a problem hiding this comment.
We shouldn't be serializing this with bincode just for a metric, directly in the publish_payload pipeline.
| Poll::Ready(Err(error)) => { | ||
| // job failed, but we simply try again next interval | ||
| debug!(target: "payload_builder", %error, "payload build attempt failed"); | ||
| match &error { |
Contributor
There was a problem hiding this comment.
I'm not sure these error metrics are useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.