Fix docker-compose port mapping to match Dockerfile#111
Merged
Conversation
The Dockerfile EXPOSEs port 8000 and the CMD uses --port 8000, but docker-compose mapped 8003:8003, causing connection refusals. - Fix port mapping from "8003:8003" to "8003:8000" (host:container) - Fix API_PORT env var from 8003 to 8000 to match actual container port The server.py middleware fix from the original PR is dropped as it was already applied on main.
8 tasks
Code ReviewLGTM — the fix is correct and well-scoped. The Dockerfile explicitly exposes and starts the server on port 8000 ( Notes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #94 — incorporates the valid docker-compose fix, drops the stale server.py changes.
"8003:8003"to"8003:8000"(host:container) — the Dockerfile exposes and listens on port 8000API_PORTenv var from8003to8000to match the actual container portThe server.py middleware fix from #94 was already applied on
main, so it's been dropped to avoid a stale diff.Credit to @BobDenar1212 for identifying both issues.
Test plan
docker compose upstarts the server accessible on host port 8003docker composeenv vars match Dockerfile defaultsCloses #94