Skip to content

Fix docker-compose port mapping to match Dockerfile#111

Merged
wshobson merged 1 commit intomainfrom
fix/mcp-discovery-and-docker-port
Mar 11, 2026
Merged

Fix docker-compose port mapping to match Dockerfile#111
wshobson merged 1 commit intomainfrom
fix/mcp-discovery-and-docker-port

Conversation

@wshobson
Copy link
Owner

Summary

Supersedes #94 — incorporates the valid docker-compose fix, drops the stale server.py changes.

  • Fix port mapping from "8003:8003" to "8003:8000" (host:container) — the Dockerfile exposes and listens on port 8000
  • Fix API_PORT env var from 8003 to 8000 to match the actual container port

The server.py middleware fix from #94 was already applied on main, so it's been dropped to avoid a stale diff.

Credit to @BobDenar1212 for identifying both issues.

Test plan

  • Verify docker compose up starts the server accessible on host port 8003
  • Verify docker compose env vars match Dockerfile defaults

Closes #94

The Dockerfile EXPOSEs port 8000 and the CMD uses --port 8000,
but docker-compose mapped 8003:8003, causing connection refusals.

- Fix port mapping from "8003:8003" to "8003:8000" (host:container)
- Fix API_PORT env var from 8003 to 8000 to match actual container port

The server.py middleware fix from the original PR is dropped as it
was already applied on main.
@claude
Copy link

claude bot commented Mar 11, 2026

Code Review

LGTM — the fix is correct and well-scoped.

The Dockerfile explicitly exposes and starts the server on port 8000 (EXPOSE 8000, --port 8000 in CMD). The old mapping 8003:8003 routed host traffic to a port the container never listened on, making the service unreachable via Docker. Both changes are correct.

Notes

  • docker-compose.yml:17 API_PORT=8000 is the right value to align with the container, but API_PORT is not read anywhere in maverick_mcp/ — the CMD hardcodes --port 8000 directly. The env var is harmless but dead; worth either wiring it up or removing it in a follow-up.
  • No other files changed, so no risk of regression elsewhere.

@wshobson wshobson merged commit f0e223c into main Mar 11, 2026
2 checks passed
@wshobson wshobson deleted the fix/mcp-discovery-and-docker-port branch March 11, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants