Skip to content

Reading whole lines from stream #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

Conversation

wurst-hans
Copy link
Owner

Replaced char-by-char retrieval from stream via fread() with fgets() to get full line from stream until EOF or newline. This speeds up data transfer by factor 10.

The original code reads single characters from stream until fread() fails, returns empty char or newline. That causes a really huge loop for retrieving emails having bigger attachments. This is not different from using fgets() which might fail or return empty string. But if there is any data, it should be trailed by a newline character. My change behaves in the same way the original code does.

Querying a simple IMAP mailbox that contains 3 emails with attachments (1x 10MB, 2x 5MB attachments), the original code runs for more than 30 seconds to retrieve the emails. Applying the change, the script finishes after 3 seconds.

Replaced char-by-char retrieval from stream via fread() with fgets() to get full line from stream until EOF or newline. This speeds up data transfer by factor 10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant