Skip to content

Conversation

xerial-bot
Copy link
Collaborator

About this PR

πŸ“¦ Updates

from 1.74.0 to 1.75.0

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "io.grpc" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.grpc" }
}]
labels: library-update

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the core gRPC libraries, specifically grpc-netty-shaded, grpc-protobuf, and grpc-stub, to version 1.75.0. This is a routine minor version bump for these dependencies, ensuring the project benefits from the latest stable features, performance improvements, and bug fixes within the gRPC ecosystem.

Highlights

  • Dependency Update: Updated io.grpc:grpc-netty-shaded, io.grpc:grpc-protobuf, and io.grpc:grpc-stub from version 1.74.0 to 1.75.0.
  • Automated Process: This update was automatically generated by Scala Steward, a tool for keeping Scala projects up-to-date with their dependencies.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with πŸ‘ and πŸ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates gRPC dependencies to version 1.75.0. While this is a straightforward version bump, the new gRPC version includes a change that could break downstream consumers of the airframe-http-grpc library. I've added a comment explaining the issue and suggesting a fix to maintain backward compatibility.

val FINAGLE_VERSION = "24.2.0"
val FLUENCY_VERSION = "2.7.3"
val GRPC_VERSION = "1.74.0"
val GRPC_VERSION = "1.75.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating to gRPC 1.75.0 introduces a potentially breaking change for the consumers of the airframe-http-grpc library.

In version 1.75.0, grpc-java changed the grpc-context dependency scope from api to implementation within grpc-api. As airframe-http-grpc depends on grpc-stub, which in turn depends on grpc-api, io.grpc.Context will no longer be on the compile classpath for your library's users. This can break their builds if they rely on this transitive dependency.

To avoid this, I recommend adding an explicit dependency on grpc-context to the airframe-http-grpc module to ensure it remains available to downstream users. For example:

libraryDependencies += "io.grpc" % "grpc-context" % GRPC_VERSION

@xerial xerial merged commit ccca979 into main Aug 29, 2025
37 of 38 checks passed
@xerial xerial deleted the update/grpc-netty-shaded-1.75.0 branch August 29, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants