di: Remove deprecated registerTraitFactory method in Scala 3 #4026
Conversation
Removed the deprecated `registerTraitFactory[A]` method and related code that was causing deprecation warnings in Scala 3. The method was marked as deprecated since version 23.9.1 with the message "Instantiating trait with DI is still experimental in Scala 3". Changes: - Removed deprecated `registerTraitFactory[A]` method from package.scala - Removed unused `registerTraitFactoryImpl[A]` and `shouldGenerateTrait[A]` functions - Removed calls to `registerTraitFactory[A]` from DesignImpl and RouterBase - Removed TraitFactoryTest.scala test file that was testing the deprecated functionality The Scala 2 implementation and related cache infrastructure remain intact for backward compatibility. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @xerial, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on refining the dependency injection framework by eliminating an experimental and deprecated trait instantiation mechanism specific to Scala 3. The primary goal is to remove compiler warnings and simplify the codebase by removing unused components, while carefully preserving compatibility for Scala 2 users. This change steers users towards more standard and stable DI binding practices.
Highlights
- Deprecated Feature Removal: The experimental registerTraitFactory method, which caused Scala 3 deprecation warnings, has been completely removed from the Scala 3 codebase.
- Codebase Cleanup: Associated unused code, including registerTraitFactoryImpl and shouldGenerateTrait functions, along with their test file TraitFactoryTest.scala, have been cleaned up.
- Backward Compatibility: The changes ensure backward compatibility for Scala 2 by retaining its existing implementation and cache infrastructure.
- Usage Impact: Users are now encouraged to utilize standard Dependency Injection (DI) binding patterns instead of the removed experimental trait instantiation feature.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request effectively removes the deprecated registerTraitFactory method and its associated code for Scala 3. The changes are logical and correctly applied across the affected files, including the removal of related tests. My review found one minor formatting issue where extra blank lines were left after code removal. Addressing this will make the cleanup even tidier. Overall, this is a solid contribution to improving the codebase.
|
|
||
| import scala.quoted.* | ||
|
|
There was a problem hiding this comment.
These extra blank lines can be removed to improve code cleanliness.
xerial
changed the title
Remove trailing blank lines from package.scala 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Summary
registerTraitFactory[A]method that was causing Scala 3 deprecation warningsChanges Made
@deprecatedregisterTraitFactory[A]method from Scala 3 package.scalaregisterTraitFactoryImpl[A]andshouldGenerateTrait[A]functionsregisterTraitFactory[A]from DesignImpl and RouterBaseTesting
diJVM/test- All tests passhttpJVM/test- All tests passImpact
This removes the experimental trait instantiation feature that was deprecated since version 23.9.1. Users should use standard DI binding patterns instead.
🤖 Generated with Claude Code