Skip to content

PageInfo: cache getBotData #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

agoujot
Copy link
Member

@agoujot agoujot commented May 3, 2025

I was on my way to add caching to it all, but actually only one query was missing it: getBotData.

That's pretty much it :). (oh, and had to tweak use a bit to return array not resultstatement (which should be fine as we iterate over it all anyhow.)

Bug: T208543

@agoujot agoujot changed the title PageInfo: cache the last uncached query PageInfo: cache getBotData May 3, 2025
Copy link

codecov bot commented May 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.99%. Comparing base (4b8eb28) to head (5e7ffe9).
Report is 85 commits behind head on main.

Files with missing lines Patch % Lines
src/Model/PageInfoApi.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #523      +/-   ##
============================================
- Coverage     71.30%   70.99%   -0.32%     
- Complexity     1275     1298      +23     
============================================
  Files            46       46              
  Lines          3792     3913     +121     
============================================
+ Hits           2704     2778      +74     
- Misses         1088     1135      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant