Skip to content

GlobalContributions: Highlight pending edits (FlaggedRevs extension) #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

agoujot
Copy link
Member

@agoujot agoujot commented May 25, 2025

Changes are roughly:

  • add method to project to get if a given project has FlaggedRevs on. for this also tweak getinstalledextensions to use projectrepository's capacity to get any project's (not only $this's) extensions
  • in globalcontribs' getrevisions, for each project, if it has flaggedrevs, outer join on flaggedpages and select whether it's pending( this check is actually ugly due to how flaggedrevs works)
  • add the pending property to edit, and an exposed method to get it, and set it using attrs' is_pending
  • add i18n for pending msg
  • add styling for pending (make it stand out just a bit less than reverted)
  • highlight and label in twig

Bug: T322466

Copy link

codecov bot commented May 25, 2025

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.09%. Comparing base (4b8eb28) to head (862dea8).
Report is 103 commits behind head on main.

Files with missing lines Patch % Lines
src/Model/Project.php 0.00% 6 Missing ⚠️
src/Model/Edit.php 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #531      +/-   ##
============================================
- Coverage     71.30%   71.09%   -0.22%     
- Complexity     1275     1299      +24     
============================================
  Files            46       46              
  Lines          3792     3913     +121     
============================================
+ Hits           2704     2782      +78     
- Misses         1088     1131      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant