document behavior of insert methods #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two possible behaviors for pre-existing keys, either the key is replaced or it is not, and which behavior is exhibited should be documented.
|
Nah these look great. Cheers mate, much appreciated. Will be put into an rc in a couple days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two possible behaviors for pre-existing keys, either the key is replaced or it is not, and which behavior is exhibited should be documented.
Not sure what the intended line length or other style restrictions on doc comments are so I've just added these short sentences on a new line. Let me know if they need to be reflowed or something.