This repository was archived by the owner on Jan 14, 2025. It is now read-only.
Update Android bindings #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
reviewed
Nov 21, 2019
|
|
||
| var pom = $"./externals/{artifact.ArtifactId}.pom"; | ||
| if (!FileExists (pom)) | ||
| DownloadFile(pomUrl, pom); |
There was a problem hiding this comment.
Download the poms so it is easy to check the dependencies. Not sure if there is another way/tool.
mattleibow
reviewed
Nov 21, 2019
| <Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
|
|
||
| <PropertyGroup> | ||
| <NoWarn>0108;0109;0114;0618</NoWarn> |
There was a problem hiding this comment.
Remove some of the warnings that are the result of the generator doing java.
mattleibow
reviewed
Nov 21, 2019
| @@ -54,14 +54,9 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Xamarin.Android.Support.Annotations" Version="27.0.2" /> | |||
| <PackageReference Include="Xamarin.Android.Support.v4" Version="27.0.2" /> | |||
| <PackageReference Include="Xamarin.Android.Support.v7.RecyclerView" Version="27.0.2" /> | |||
There was a problem hiding this comment.
Removed the dependencies that were not in the pom.
mattleibow
added
needs-review
This is for the other tools in the pipeline template. Rather skip what we can't do on Windows.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.