This repository was archived by the owner on Jan 13, 2025. It is now read-only.
Update Kotlin to v1.2.71 #643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dropped the version to v1.2.71 (the latest v1.2 before upgrading) - using binderator instead of manual projects - using targets files instead of embedded jars
mattleibow
force-pushed
the
dev/kotlin-binding
branch
from
42a70c9 to
798b2ef
Compare
mattleibow
commented
Aug 15, 2019
| <PackageReference Include="@(dep.NuGetPackageId)" Version="@(dep.NuGetVersion)" /> | ||
| } | ||
| } | ||
| <PackageReference Include="Xamarin.Kotlin.BindingSupport" Version="0.1.0-preview" PrivateAssets="All" /> |
There was a problem hiding this comment.
This is the new tool in use - just meant for binding projects, and should have all its assets private.
This will cause the build to fail, because this package is not yet released: #642
mattleibow
commented
Aug 15, 2019
|
|
||
| <ItemGroup> | ||
| @foreach (var art in @Model.MavenArtifacts) { | ||
| <AndroidJavaLibrary Include="$(MSBuildThisFileDirectory)..\..\jar\@(art.MavenGroupId).@(art.MavenArtifactId).jar" /> |
There was a problem hiding this comment.
Using the new AndroidJavaLibrary element so as to avoid embedding the jars in the dll.
mattleibow
added
needs-review
Redth
approved these changes
Sep 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few things:
This PR also works around a few issues in the generator stack:
generator --only-xml-adjusterdotnet/java-interop#466