[generator] Emit [EditorBrowsable(false)] and [DebuggerBrowsable(false)] for JLO machinery. #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
commented
Aug 26, 2020
| @@ -45,6 +45,7 @@ public static class Compiler | |||
| MetadataReference.CreateFromFile (unitTestFrameworkAssemblyPath), | |||
| MetadataReference.CreateFromFile (typeof(object).Assembly.Location), | |||
| MetadataReference.CreateFromFile (typeof(Enumerable).Assembly.Location), | |||
| MetadataReference.CreateFromFile (typeof(Uri).Assembly.Location), | |||
There was a problem hiding this comment.
(This is to reference System.)
jpobst
force-pushed
the
editorbrowsable
branch
from
c3e8507 to
d9ce04e
Compare
jonpryor
reviewed
Aug 27, 2020
| { | ||
| public override void WriteAttribute (CodeWriter writer) | ||
| { | ||
| writer.WriteLine ("[DebuggerBrowsable (DebuggerBrowsableState.Never)]"); |
There was a problem hiding this comment.
I worry whenever we don't global::… fully qualify a type reference, as this has bitten us before. (I'd swear there's a current instance where we need-to-but-don't emit global:…, but I can't find it.)
…e)] for JLO machinery.
jpobst
force-pushed
the
editorbrowsable
branch
from
d9ce04e to
544ed19
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#4582
Fixes: #688
In dotnet/android#4582 we hid "internal" methods like
Java.Lang.Object.ThresholdClassfrom the editor and debugger using[DebuggerBrowsable (DebuggerBrowsableState.Never)]and[EditorBrowsable (EditorBrowsableState.Never)]. However our bindings override some of these methods/properties and need to also apply these attributes or else they still show up in IDEs.