Skip to content
This repository was archived by the owner on Dec 10, 2024. It is now read-only.

chore: add report type to MergeRequestApprovalRule#1975

Merged
svanharmelen merged 2 commits intoxanzy:mainfrom
mdevilliers:patch-1
Aug 3, 2024
Merged

chore: add report type to MergeRequestApprovalRule#1975
svanharmelen merged 2 commits intoxanzy:mainfrom
mdevilliers:patch-1

Conversation

@mdevilliers
Copy link
Copy Markdown
Contributor

@mdevilliers mdevilliers commented Jul 24, 2024

This attribute has been added to the approval_rules object -

https://docs.gitlab.com/ee/api/merge_request_approvals.html#get-merge-request-level-rules

It should be returned by the enterprise edition and was added to gitlab with this PR - https://gitlab.com/gitlab-org/gitlab/-/merge_requests/155772.
That functionality was required as part of this PR against the terraform provider - https://gitlab.com/gitlab-org/terraform-provider-gitlab/-/merge_requests/1913

Happy to add a test but was wondering about it being an EE only feature?

Copy link
Copy Markdown
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mdevilliers 👍🏻

@svanharmelen svanharmelen merged commit 9cafcb7 into xanzy:main Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants