Skip to content

docs: updated comments to reflect pnpm usage instead of yarn #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2025
Merged

docs: updated comments to reflect pnpm usage instead of yarn #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/integration-tests/tools/pack-packages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,13 @@ export const setup = async (project: TestProject): Promise<void> => {
),
{ encoding: 'utf-8' },
);
// TODO!: Rewrite
// We install the tarballs here once so that yarn can cache them globally.

// We install the tarballs here once so that pnpm can cache them globally.
// This solves 2 problems:
// 1. Tests can be run concurrently because they won't be trying to install
// the same tarballs at the same time.
// 2. Installing the tarballs for each test becomes much faster as Yarn can
// grab them from the global cache folder.
// 2. Installing the tarballs for each test becomes much faster as pnpm can
// reuse them from its global content-addressable store.
await execFile('pnpm', ['install', '--no-frozen-lockfile'], {
cwd: temp,
shell: true,
Expand Down
3 changes: 1 addition & 2 deletions tools/scripts/postinstall.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ import { $ as $_config } from 'execa';

const $ = $_config({
env: {
// TODO!: Check it out and, if necessary, rewrite it
/**
* Do not apply the special GitHub Actions group markers within the
* postinstall logging, it cannot work correctly when nested within
* yarn's output and therefore just adds visual noise.
* pnpm's output and therefore just adds visual noise.
*/
NX_SKIP_LOG_GROUPING: 'true',
},
Expand Down
Loading