add_bounds uses keys rather than dims
#221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #221 +/- ##
=======================================
Coverage 96.45% 96.46%
=======================================
Files 12 12
Lines 1551 1555 +4
=======================================
+ Hits 1496 1500 +4
Misses 55 55
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dcherian
reviewed
May 3, 2021
cf_xarray/accessor.py
Outdated
Comment on lines
1615
to
1619
| dimensions = set() | ||
| for key in keys: | ||
| dimensions |= set( | ||
| apply_mapper(_get_dims, self._obj, key, error=False, default=[key]) | ||
| ) |
There was a problem hiding this comment.
A set comprehension is cleaner here
Suggested change
| dimensions = set() | |
| for key in keys: | |
| dimensions |= set( | |
| apply_mapper(_get_dims, self._obj, key, error=False, default=[key]) | |
| ) | |
| dimensions = { | |
| apply_mapper(_get_dims, self._obj, key, error=False, default=[key]) | |
| for key in keys | |
| ) |
There was a problem hiding this comment.
Actually shouldn't the default be key instead of [key] given that you're doing set subttraction later.
There was a problem hiding this comment.
apply_mapper returns a list of dimension names, shouldn't default do the same?
Regarding the set comprehension, this wouldn't work: {["dim1", "dim2"], ["dim3"]}.
How about this?
dimensions = {dim for key in keys for dim in apply_mapper(_get_dims, self._obj, key, error=False, default=[key])}Or we could use update:
dimensions = set()
for key in keys:
dimensions.update(apply_mapper(_get_dims, self._obj, key, error=False, default=[key]))
dcherian
added a commit
to jthielen/cf-xarray
that referenced
this pull request
May 18, 2021
* upstream/main: Update README.rst Add earthcube 2021 notebook link to readme v0.5.2 Some CMIP6 support Add pooch to binder environment (xarray-contrib#223) `add_bounds` uses `keys` rather than `dims` (xarray-contrib#221)
dcherian
added a commit
to jukent/cf-xarray
that referenced
this pull request
Jun 8, 2021
* main: (57 commits) Add CITATION.cff, tributors, zenodo.json (xarray-contrib#231) Add zenodo badge Improve `rename_like` (xarray-contrib#222) Don't apply mappers to DataArrays (xarray-contrib#227) Add unit support to cf-xarray (xarray-contrib#197) Update README.rst Add earthcube 2021 notebook link to readme v0.5.2 Some CMIP6 support Add pooch to binder environment (xarray-contrib#223) `add_bounds` uses `keys` rather than `dims` (xarray-contrib#221) Add .cf.formula_terms (xarray-contrib#213) Update whats-new.rst (xarray-contrib#217) add bounds property (xarray-contrib#214) Update some tests. Compile regexes Fix black Add __version__ (xarray-contrib#208) add skip to rename_like (xarray-contrib#206) Refactor out coordinate criteria to criteria.py (xarray-contrib#205) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.