Skip to content

Single layer for cohorts. #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Jan 19, 2025
Merged

Single layer for cohorts. #415

merged 30 commits into from
Jan 19, 2025

Conversation

dcherian
Copy link
Collaborator

@dcherian dcherian commented Jan 15, 2025

Closes #396

| Before [df81| After [761367dc] |   Ratio | Benchmark (Parameter)                                    |
|-------------|------------------|---------|----------------------------------------------------------|
| 3672        | 4266             |    1.16 | cohorts.ERA5MonthHourRechunked.track_num_tasks_optimized |
| 3834        | 3469             |    0.9  | cohorts.ERA5DayOfYear.track_num_tasks                    |
| 999±20ms    | 822±60ms         |    0.82 | cohorts.ERA5Resampling.time_graph_construct              |
| 11          | 6                |    0.55 | cohorts.ERA5MonthHourRechunked.track_num_layers          |
| 10          | 5                |    0.5  | cohorts.ERA5MonthHour.track_num_layers                   |
| 17          | 5                |    0.29 | cohorts.PerfectMonthly.track_num_layers                  |
| 128         | 5                |    0.04 | cohorts.ERA5Google.track_num_layers                      |
| 266         | 6                |    0.02 | cohorts.NWMMidwest.track_num_layers                      |
| 735         | 5                |    0.01 | cohorts.ERA5DayOfYear.track_num_layers                   |
| 490         | 6                |    0.01 | cohorts.OISST.track_num_layers                           |
| 7305        | 5                |    0    | cohorts.ERA5Resampling.track_num_layers                  |

@dcherian dcherian marked this pull request as ready for review January 18, 2025 23:06
@dcherian dcherian enabled auto-merge (squash) January 18, 2025 23:51
@dcherian dcherian disabled auto-merge January 18, 2025 23:52
@dcherian dcherian enabled auto-merge (squash) January 18, 2025 23:53
@dcherian dcherian merged commit e2aa2be into main Jan 19, 2025
15 of 16 checks passed
@dcherian dcherian deleted the optimize-tree-reduce-layer branch January 19, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework cohorts algorithm and heuristics
1 participant