Skip to content

initial documentation #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 3, 2020
Merged

initial documentation #13

merged 6 commits into from
Jul 3, 2020

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Jul 2, 2020

Initial skeleton of the documentation. I'm using my (unreleased) sphinx-autosummary-accessors project to format the accessor pages properly, which seems to work just fine.

@keewis
Copy link
Collaborator Author

keewis commented Jul 2, 2020

It seems we need to merge this before we can get PR builds with RTD.

@TomNicholas: The only thing I'd need you to review for now is the use of sphinx-autosummary-accessors. That project is close enough so I can't see much harm in installing it from github.

Also, if you sign up for RTD (using github, if you want), I can add you as a maintainer – you don't have to, there's not much to maintain anyways.

@keewis
Copy link
Collaborator Author

keewis commented Jul 3, 2020

merging. If there's something wrong, we can always open a new PR.

@keewis keewis merged commit b221cb0 into xarray-contrib:master Jul 3, 2020
@keewis keewis deleted the docs branch July 3, 2020 09:03
@keewis
Copy link
Collaborator Author

keewis commented Jul 3, 2020

actually, it seems RTD didn't trigger because it didn't receive any authentication for the webhook.

@TomNicholas: what do you think about moving this to a different organization, e.g. xarray-contrib?

@TomNicholas
Copy link
Member

Thanks for this!

what do you think about moving this to a different organization, e.g. xarray-contrib?

I'm happy for it to live anywhere. Seeing that xarray-contrib now contains cf-xarray, then it seems like a good place? My only question would be how do the permissions work then? We probably want to give access to people already in xarray-contrib and any of the pint contributors/people contributing here who are interested.

@keewis
Copy link
Collaborator Author

keewis commented Jul 8, 2020

That should be possible. All members of an organization automatically have access (Member), and we can also invite people to maintain a single repository (Collaborator).

@TomNicholas
Copy link
Member

Okay, in that case I suggest we ask about it in the xarray community meeting this afternoon.

@TomNicholas
Copy link
Member

Okay, in that case I suggest we ask about it in the xarray community meeting this afternoon.

"Yes please!" said Stephan. I'll see if I can do that now.

@TomNicholas
Copy link
Member

@keewis I just moved it - access seems to be as expected. I also sent an invite to @jthielen for write access

@jthielen
Copy link
Collaborator

jthielen commented Jul 8, 2020

@TomNicholas Got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants